Convert initial value that comes as int to a list of flag names. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing an object the widget works as expected. The exception occurs only when adding a new object.
added 2 commits
June 10, 2013 13:56
bitfield/forms.py
Outdated
| @@ -25,6 +25,13 @@ def _has_changed(self, initial, data): | |||
|
|
|||
| class BitFormField(IntegerField): | |||
| def __init__(self, choices=(), widget=BitFieldCheckboxSelectMultiple, *args, **kwargs): | |||
| if isinstance(kwargs['initial'],int): | |||
There was a problem hiding this comment.
needs a space after the comma
also initial isnt guaranteed to be in kwargs
|
My feedback is all stylistic though I think the approach may not be very correct. This is making the assumption that there's a 64 bit integer. |
|
Thanks for the feedback!.
The shift operation is promoted to long when int is 32 bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing an object the widget works as expected.
Exception occurs when adding a new object.